12468 disallow double underscores in custom field names #12523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
For model field changes that don't actually modify the database schema (such as modifying application-level validators as in this case), we can just tweak the most recent definition of the field in the existing migrations. This happens to be 0066_customfield_name_validation. Also: Rather than modifying the existing regex, it might be cleaner to add a second regex validator to check specifically for double underscores. This will allow us to use simpler expressions and to provide separate error messages to the user. |
Collaborator
Author
|
@jeremystretch updated. |
jsenecal
pushed a commit
to jsenecal/netbox
that referenced
this pull request
May 18, 2023
…nity#12523) * 12468 disallow double underscores in custom field names * 12468 disallow double underscores in custom field names * 12468 review changes * 12468 correct migration * 12468 use inverse match * 12468 use inverse match * Add test for invalid custom field names --------- Co-authored-by: jeremystretch <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12468
Disallow double-underscore in custom field names. Unfortunately creates a migration, Jeremy what is the official way to suppress this migration?