Skip to content

Conversation

@decoupca
Copy link
Contributor

@decoupca decoupca commented Apr 13, 2023

Fixes: #11623

  • Changes PSK fields to PasswordInputs in edit views
  • Obfuscates PSK on object view with show/hide toggle

@decoupca decoupca force-pushed the 11623-hide-wifi-secrets branch from d48b9f0 to 8903478 Compare April 13, 2023 16:55
@decoupca
Copy link
Contributor Author

@jeremystretch I'm not clear on what I need to push to pass CI checks, please advise

@abhi1693
Copy link
Member

Try running the following and commit. You are basically missing generated static files

cd netbox/project-static
yarn
yarn bundle

@decoupca
Copy link
Contributor Author

decoupca commented Apr 13, 2023

@abhi1693

Try running the following and commit. You are basically missing generated static files

cd netbox/project-static
yarn
yarn bundle

When I do that and run git status:

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   dist/graphiql.js.map
        modified:   dist/netbox.js
        modified:   dist/netbox.js.map
        modified:   package.json
        modified:   yarn.lock

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        .yarn/
        .yarnrc.yml

If I do git add . then git commit it adds a bunch of stuff, tens of megabytes of what looks like yarn build environment stuff. Do I include all that?

@kkthxbye-code
Copy link
Contributor

@decoupca - these are the ones you are supposed to push:

    modified:   dist/netbox.js
    modified:   dist/netbox.js.map

However as you've modified package.json it will probably still fail. The .yarn folder and .yarnrc.yml files are probably because you have installed global yarn packages, also not something you should push.

You can revert all that, delete node_modules or whatever it's called and just simply do a yarn and yarn bundle and push the two files I specified.

@decoupca
Copy link
Contributor Author

@kkthxbye-code I started from a clean working tree, reran yarn and yarn bundle, ended up with the same git status as before. But pushed only your 2 files, all good. Not sure where all the other changes came from.

@jeremystretch
Copy link
Member

Thanks @decoupca!

@jeremystretch jeremystretch merged commit adb9673 into netbox-community:develop Apr 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hide WIFI password

4 participants