7503 do device validate-create in serial #12222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthanson
changed the title
jeremystretch
force-pushed
the
7503-bulk-create-rack-space
branch
from
819db7e to
b5f9fe6
Compare
netbox/dcim/api/views.py
Outdated
| return serializers.DeviceWithConfigContextSerializer | ||
|
|
||
| @transaction.atomic | ||
| def create(self, request, *args, **kwargs): |
Member
There was a problem hiding this comment.
IMO we should move this to a mixin class in case we need it for other views in the future.
Member
|
I've moved the |
Collaborator
Author
|
@jeremystretch looks good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7503
Makes Device ViewSet to object validation and creation serial, instead of validating all at once then creating all at once - to catch conditions like overlapping rack locations.