Skip to content

Conversation

@abhi1693
Copy link
Member

Closes: #11645

When recurs every is set but schedule at is left empty, local time displayed on the form will be used instead.

@jeremystretch
Copy link
Member

Could you replicate this change to ReportForm as well please?

@abhi1693
Copy link
Member Author

Is there any specific reason that ScriptForm has fields with underscore and ReportForm does not?

@jeremystretch
Copy link
Member

Yes; reports don't take any user input, so we're free to declare whatever form fields we want. Scripts, however, can declare their own form fields with any names, which could potentially conflict with the built-ins we add. So, we prepend the built-in field names with underscores as it makes a collision much less likely and helps to differentiate them from the script's own fields.

@jeremystretch
Copy link
Member

Thanks for taking this!

@jeremystretch jeremystretch merged commit 1d2335d into netbox-community:develop Mar 28, 2023
@abhi1693 abhi1693 deleted the feat/11645 branch March 28, 2023 15:04
jeremystretch pushed a commit that referenced this pull request Mar 28, 2023
* updated _schedule_at to use local time when _interval is set

* updated schedule_at to use local time when interval is set
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom script scheduling when only interval is set

2 participants