Skip to content

Conversation

@jeremystretch
Copy link
Member

Fixes: #11539

  • Clean up our custom Empty lookup to more accurately evaluate true/false conditions
  • Force the use of BooleanFilter for empty lookups in requests

While this seems to address the bug for most fields, I still need to figure out how to correct the filter class for declared filters, such DeviceFilterSet.name (which is the actual target of the bug report).

@jeremystretch jeremystretch marked this pull request as ready for review May 25, 2023 18:53
@jeremystretch jeremystretch merged commit 24a51dd into develop May 25, 2023
@jeremystretch jeremystretch deleted the 11539-empty-lookups branch May 25, 2023 19:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Insufficent validation of boolean filters

2 participants