Fixes #11601 - Add partial lookup to IPRangeFilterSet #11697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
My guess is it was mistakenly copied over from PrefixFilterSet back when IP ranges were introduced. (It's used there to match based on a contained IP address.) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11601
Allows partial lookup in the search method for IPRange. Also removes the
.cidrfrom the parsed IP lookup as I really don't see how it makes sense.The changes makes it so that the following matches (192.168.0.1/25-192.168.0.25/25, which didn't before:
192
192.16
192.168.0.1/25 <- even the full IP with mask didn't match before because of using the cidr.
192.168.0.25/25