Closes #11152: Add support to abort custom script gracefully #11621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested changes
Feb 2, 2023
Member
jeremystretch
left a comment
jeremystretch
left a comment
There was a problem hiding this comment.
A couple very minor notes, but this is great work! Thank you!
Member
|
@BarbarossaTM thanks for this! Do you think it would make sense to implement this functionality for reports too? (I'd be fine reusing the same |
…cefully Signed-off-by: Maximilian Wilhelm <[email protected]>
BarbarossaTM
force-pushed
the
11152-report-script-errors
branch
from
ff2dd4a to
3c92787
Compare
Member
|
Thanks @BarbarossaTM! |
Contributor
Author
|
Thanks for the native speaker language polish :-) I haven't used report myself yet, but I assume it might be useful there too, I guess the place to do it there would be in Do you want to me look into this and file another PR? |
Member
|
If you'd like to. Or we can wait and see if this gets any feedback first. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11152
This PR adds a new
AbortScriptexception which a custom script can throw in case the script should be terminated cleanly. It allows specifying an error message which will be reported to the user, but no stack trace is shown. Any other unhandled exception will still raise a stacktrace.