Skip to content

Fixes #11267: Avoid catching ImportError exceptions when loading plugins #11566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 27, 2023
Merged

Fixes #11267: Avoid catching ImportError exceptions when loading plugins #11566

merged 2 commits into from
Jan 27, 2023

Conversation

@jeremystretch
Copy link
Member

@jeremystretch jeremystretch commented Jan 23, 2023 •
edited
Loading

Fixes: #11267

  • Employ module_has_submodule() to check for presence of plugin URL patterns
  • Remove default paths from PluginConfig class
  • If plugin resource path has not been explicitly set, use find_spec() to check default path before importing

@jeremystretch jeremystretch mentioned this pull request Jan 23, 2023
Closed
@jeremystretch jeremystretch marked this pull request as ready for review January 24, 2023 22:13
@jsenecal jsenecal self-requested a review January 27, 2023 14:59
jsenecal
jsenecal approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@jsenecal jsenecal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice reuse of django builtins

@jeremystretch jeremystretch merged commit fbc9fea into develop Jan 27, 2023
@jeremystretch jeremystretch deleted the 11267-plugin-imports branch January 27, 2023 21:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@arthanson arthanson Awaiting requested review from arthanson

1 more reviewer

@jsenecal jsenecal jsenecal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ImportErrors inside plugins are currently ignored → add logging

3 participants

@jeremystretch @jsenecal