added l2vpn_termination on vlan filterset #11501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
From the use case cited in #11118, it seems the goal here is to enable filtering VLANs by associated L2VPN, rather than by their directly associated terminations. Filtering by the termination ID probably isn't very useful, because 1) it will only return one VLAN per termination, and 2) if you know the termination ID you likely already have the VLAN ID. |
Member
Author
|
Alright, I guess I misunderstood the issue, I'll try again on this |
Member
Author
|
@jeremystretch I have made the change as per your comment. Hopefully, I got it right this time |
Member
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11118