Set *_COOKIE_PATH according to BASE_PATH #10706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in netbox-community#10639, all three `COOKIE_PATH`s should be set accordingly with the netbox-`BASE_PATH` to improve coexistance with other Django-projects probably hosted on the same Host
Member
|
CI failure is unrelated; see #10712. |
Contributor
|
Unfortunately this change sets an invalid cookie path which prevents login: #10837 |
candlerb
added a commit
to candlerb/netbox
that referenced
this pull request
Nov 5, 2022
jeremystretch
pushed a commit
that referenced
this pull request
Nov 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10639
All three
COOKIE_PATHs should be set accordingly with the netbox-BASE_PATHto improve coexistance with other Django-projects probably hosted on the same Host