Skip to content

Conversation

@jeremystretch
Copy link
Member

Fixes: #10247

This work affects all device components, all device component templates, and VM interfaces. At a high level, we've switched from rendering two individual forms for component creation to a single new per-model creation form, which inherits from both ComponentCreateForm as well as the pertinent model form. This enables us to efficiently render the form and ditch a number of custom templates.

patterned_fields on the component creation views has been replaced with replication_fields, which is now defined on the form for more robust validation. Additionally, name_pattern and label_pattern have been renamed to name and label, and now replace the model form fields of the same names.

@jeremystretch jeremystretch marked this pull request as ready for review September 9, 2022 19:46
@jeremystretch
Copy link
Member Author

I still need to fix bulk component creation (e.g. for multiple objects).

@jeremystretch jeremystretch merged commit c4b7ab0 into develop Sep 15, 2022
@jeremystretch jeremystretch deleted the 10247-vminterface-create branch September 15, 2022 14:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Virtual machine selection on Add a new interface not recognised

2 participants