Interface Role have extra entry 'r'

[Domoninic]

NetBox version

V3.2.2

Python version

3.8

Steps to Reproduce

1: Create / Edit IP address
2: Open Role Drop-down and scroll to bottom

Expected Behavior

Last entry is "CARP"

Observed Behavior

Last entry is "r"

This is observed in both local install and online Demo

[steffenkremser]

Seems to be a typo in b3ea007

    CHOICES = (
        (ROLE_LOOPBACK, 'Loopback', 'gray'),
        (ROLE_SECONDARY, 'Secondary', 'blue'),
        (ROLE_ANYCAST, 'Anycast', 'yellow'),
        (ROLE_VIP, 'VIP', 'purple'),
        (ROLE_VRRP, 'VRRP', 'green'),
        (ROLE_HSRP, 'HSRP', 'green'),
        (ROLE_GLBP, 'GLBP', 'green'),
        (ROLE_CARP, 'CARP'), 'green',
    )

i.e. the ROLE_CARP tuple is closed prematurely (after just 2 elements)
.. the leftover literal 'green' is treated as a separate choice ['g','r','e',...]
.. and thus displayed as r (second element is display_value)

.. the obvious fix being

-        (ROLE_CARP, 'CARP'), 'green',
+        (ROLE_CARP, 'CARP', 'green'),

[kkthxbye-code]

@steffenkremser - I submitted a PR. Thank you for doing the digging 👍