Inconsistent UX in VLAN groups create and edit forms when changing scope type

[stephanblanke]

NetBox version

v3.1.8

Python version

3.8

Steps to Reproduce

1. Open /ipam/vlan-groups/add/
2. Enter a name
3. Change Scope type to "DCIM > site"
4. Select a site
5. Click "Create"
6. Click "Edit" to edit the newly created VLAN group
7. Change scope type to "Virtualization > cluster"

Expected Behavior

Changing the scope type should dynamically show/hide the fields (region, site group, site, location, rack, cluster group and cluster) in the create form.

Observed Behavior

Changing the scope type does not hide any fields in the create form. The expected behavior can be seen in the edit form.

[stephanblanke]

I can try to implement this. PR is on its way.

[jeremystretch]

I was just looking into this, and it seems to be tied to differing values for data-netbox-url-name. I'm not entirely sure how this is intended to work; maybe @thatmattlove can shed some light?

[stephanblanke]

From my point of view we just have to duplicate the following lines and name the dict vlangroup_add:

netbox/netbox/project-static/src/forms/scopeSelector.ts

Lines 30 to 71 in ddff193

	vlangroup_edit: {
	region: {
	hide: ['id_sitegroup', 'id_site', 'id_location', 'id_rack', 'id_clustergroup', 'id_cluster'],
	show: ['id_region'],
	},
	'site group': {
	hide: ['id_region', 'id_site', 'id_location', 'id_rack', 'id_clustergroup', 'id_cluster'],
	show: ['id_sitegroup'],
	},
	site: {
	hide: ['id_location', 'id_rack', 'id_clustergroup', 'id_cluster'],
	show: ['id_region', 'id_sitegroup', 'id_site'],
	},
	location: {
	hide: ['id_rack', 'id_clustergroup', 'id_cluster'],
	show: ['id_region', 'id_sitegroup', 'id_site', 'id_location'],
	},
	rack: {
	hide: ['id_clustergroup', 'id_cluster'],
	show: ['id_region', 'id_sitegroup', 'id_site', 'id_location', 'id_rack'],
	},
	'cluster group': {
	hide: ['id_region', 'id_sitegroup', 'id_site', 'id_location', 'id_rack', 'id_cluster'],
	show: ['id_clustergroup'],
	},
	cluster: {
	hide: ['id_region', 'id_sitegroup', 'id_site', 'id_location', 'id_rack'],
	show: ['id_clustergroup', 'id_cluster'],
	},
	default: {
	hide: [
	'id_region',
	'id_sitegroup',
	'id_site',
	'id_location',
	'id_rack',
	'id_clustergroup',
	'id_cluster',
	],
	show: [],
	},
	},

.

I did a quick test locally and the results look promising. As soon as I can get the pre-commit hooks running, I can commit the change to my fork and create a PR.

[jeremystretch]

From my point of view we just have to duplicate the following lines

I'm afraid that simply duplicating the code isn't a tenable solution. We need to ensure that the existing code is used for both views.