-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Closed
Labels
status: acceptedThis issue has been accepted for implementationThis issue has been accepted for implementationtype: bugA confirmed report of unexpected behavior in the applicationA confirmed report of unexpected behavior in the application
Description
NetBox version
v3.1.6-dev
Python version
3.9
Steps to Reproduce
- Create a device
- Create interface
- View device under the interface tab
- Press delete
Expected Behavior
Delete modal pops up
Observed Behavior
Nothing happens.
Cause: #8231
The reason is that some tabs already define the modal block in their template:
netbox/netbox/templates/dcim/device/interfaces.html
Lines 82 to 84 in f1472d2
| {% block modals %} | |
| {% table_config_form table %} | |
| {% endblock modals %} |
Changing it to:
{% block modals %}
{% include 'inc/htmx_modal.html' %}
{% table_config_form table %}
{% endblock modals %}fixes the issue. When the tabs templates define the modal, they don't get the default modal defined in generic/object.html
This is an issue in all templates that overwrite the modals block and use the htmx modal.
Examples:
dcim/device/interfaces.htmldcim/device/frontports.htmldcim/device/rearports.htmldcim/device/consoleports.html
etc.
Metadata
Metadata
Assignees
Labels
status: acceptedThis issue has been accepted for implementationThis issue has been accepted for implementationtype: bugA confirmed report of unexpected behavior in the applicationA confirmed report of unexpected behavior in the application