Incorrect import CSV with multiline values

[seros1521]

NetBox version

v3.0.8

Python version

3.7

Steps to Reproduce

1.open the CSV file import page for Sites
2.import a CSV file with the following content:

name,slug,status,comments
name1,slug1,active,"multiline
comment"

Expected Behavior

The "comments" field is expected to preserve the line break.

Observed Behavior

When importing a file, the line break in the multi-line comments field disappears.
When importing through the "CSV Data" form, the import is correct, the line feed is preserved.

[seros1521]

Different behavior occurs due to different way of processing input data:

netbox/netbox/utilities/forms/fields.py

Line 190 in 26ceeb6

reader = csv.reader(StringIO(value.strip()))

and

netbox/netbox/utilities/forms/fields.py

Line 227 in 26ceeb6

reader = csv.reader(csv_str.splitlines())

Demo:

>>> import csv
>>> from io import StringIO
>>> s="""name,slug,status,comments
... name1,slug1,active,"multiline
... comment"
... """
>>> 
>>> [i for i in s.splitlines()]
['name,slug,status,comments', 'name1,slug1,active,"multiline', 'comment"']
>>> 
>>> [i for i in StringIO(s)]
['name,slug,status,comments\n', 'name1,slug1,active,"multiline\n', 'comment"\n']
>>> 
>>> [i for i in csv.reader(s.splitlines())]
[['name', 'slug', 'status', 'comments'], ['name1', 'slug1', 'active', 'multilinecomment']]
>>> 
>>> [i for i in csv.reader(StringIO(s))]
[['name', 'slug', 'status', 'comments'], ['name1', 'slug1', 'active', 'multiline\ncomment']]
>>> 

[DanSheps]

Can you comment your test cases?

To clarify, StringIO is the desired import right?

When importing a file, the line break in the multi-line comments field disappears.
When importing through the "CSV Data" form, the import is correct, the line feed is preserved.

Could you also clarify this? What is the case for each?