NewVersion showing url

[PieterL75]

NetBox version

v3.0.7

Python version

3.7

Steps to Reproduce

When a new release is available, Netbox wil inform the admins about it.

Fix :

netbox/netbox/netbox/views/__init__.py

Line 140 in 1f4263a

'version': str(latest_release),

replace that with
'version': str(release_verion),

Expected Behavior

A nice view with the new version number, with an hyperlink to the release on github

Observed Behavior

The version is shown with the url, but containing the git url as text, rather than an hyperlink

[apellini]

If I use following regex:
import re
re.search("([0-9].[0-9].[0-9])", str(latest_release)).string

Could it help to solve?

Regards,

Aldo Pellini

[PieterL75]

The fix is mentioned in the bug..

Fix :

netbox/netbox/netbox/views/__init__.py

Line 140 in 9c6938e

'version': str(latest_release),

replace that with
'version': str(release_verion),

but I gave it a shot and created a pull request #7566

[DanSheps]

Pieter, please make sure you also update the changelog (although if you are uncomfortable doing it when can take care of this on merge)

[PieterL75]

Still need to figure out Pull Requests .. I now have two... Sorry about that...

[DanSheps]

You just add a new commit to the branch you were working on to add the existing commit.

[PieterL75]

Daniel, I updated the existing PR with the release notes update.. Sorry for the work you have me, it was probably easier to do it yourself.. But on the other hand, ty for guiding me to get this done.. It will be helpful when I see other small quick-fix things that you dont have to be bothered with Pieter Op di 19 okt. 2021 om 15:45 schreef Daniel Sheppard < ***@***.***>:

…

You just add a new commit to the branch you were working on to add the existing commit. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#7556 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AR3OADGWMXDJUSKK65RMAY3UHVZAVANCNFSM5GF3GFLQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.