VLANGroup CSV import incorrectly states 'site' as a column

[sdktr]

NetBox version

v.2.11.10

Python version

3.8

Steps to Reproduce

Open VlanGroup CSV import (https://demo.netbox.dev/ipam/vlan-groups/import/)

Expected Behavior

Valid columns are displayed as option in helper table

Observed Behavior

According to #6897 'site' should not be directly referenced. Since v2.11 we expect a scope_type and scope_id

[candlerb]

The spurious "site" column probably comes from VLANGroupCSVForm.

[sdktr]

The spurious "site" column probably comes from VLANGroupCSVForm.

I assumed as well. But not sure how that form is supposed to look. Maybe deleting the site reference is enough to fix both this bug and #6910 but my guess is that one requires some other fixes to the form as well.

[candlerb]

The nearest existing working code I can find with GenericForeignKey is assigned_object_type and assigned_object_id in IPAddress.

However, IPAddressCSVForm does not have separate fields for assigned_object_type and assigned_object_id; it just has interface, and internally the queryset is updated to either Interface.objects.filter(...) or VMInterface.objects.filter(...) as appropriate.

I also note that the way IPAddress limits its models:

    assigned_object_type = models.ForeignKey(
        to=ContentType,
        limit_choices_to=IPADDRESS_ASSIGNMENT_MODELS,

# where
IPADDRESS_ASSIGNMENT_MODELS = Q(
    Q(app_label='dcim', model='interface') |
    Q(app_label='virtualization', model='vminterface')
)

is slightly different to how VLANGroup does it:

    scope_type = models.ForeignKey(
        to=ContentType,
        ...
        limit_choices_to=Q(model__in=VLANGROUP_SCOPE_TYPES),

# where
VLANGROUP_SCOPE_TYPES = (
    'region', 'sitegroup', 'site', 'location', 'rack', 'clustergroup', 'cluster',
)

But this is all deep Django magic to me.