VLANs available not shown correct

[PieterL75]

NetBox version

v2.10.5

Python version

3.7

Steps to Reproduce

Open a VLAN Group
Looks for the 'xxx Vlans Available'

Expected Behavior

The exact number of available vlans

Observed Behavior

The number of available vlans is not correct.
Between 1528 and 1528, there is 1 available shown
Between 1529 and 1530, there are 2566 available shown

I have the same issue on my DEV box that is running v2.11.0.

Unfortunately I don't know when or how it appeared, I just noticed it today.

[jeremystretch]

Thank you for opening a bug report. I was unable to reproduce the reported behavior on NetBox v2.11.1. Please re-confirm the reported behavior on the current stable release and adjust your post above as necessary. Remember to provide detailed steps that someone else can follow using a clean installation of NetBox to reproduce the issue. Remember to include the steps taken to create any initial objects or other data.

[PieterL75]

Jeremy,

It looks that the issue occurs when creating a new vlan in a 'script' py.

      newvid=self.getnextfreevlan(vlangroup.id,51,100)
      if newvid == None:
         self.log_failure(f"Unable to select a free vlan in the 51-100 range")
      else:
         vlanname = f"CUST-{name}-{newvid}"
         newvlan = VLAN(
            vid = newvid,
            name = vlanname,
            group = vlangroup,
         )
         newvlan.save()
         for tag in data['env_tags']:
            newvlan.tags.add(tag.name)
         self.log_success(f"Vlan Selected : [{vlanname} ({newvid})](/ipam/vlans/{newvlan.id}/)")

   def getnextfreevlan(self, groupid, minvid, maxvid):
      vlan_ids = VLAN.objects.filter(group=groupid).values_list('vid', flat=True)
      for x in range(minvid, maxvid):
         if x not in vlan_ids:
            return x

After that, the free vlans are messed up

Is this because of the way the new vlan is created ? Am I missing some crucial step in the code ?

Pieter

[PieterL75]

I flushed the database, and upgrade to v2.11.1.
Now the same actions don't do this behavior.

Next step, was to revert back to my database, upgrade to v2.11.1. but that does the same strange thing again.
Looks like something got corrupted in my database..

So I took an export of my VLANS to csv, and then I noticed, that the vlans where it goes wrong, had a Group, but no Site value:

After correcting the Site to a good value, the available vlans were correct again

I updated the script so that it will add the site id to the vlan

   def run(self, data, commit):
      name=data['env_name'].upper()
      snl=int(data['env_snl'])
      prefix=data['env_prefix'].prefix
      pfx=Prefix.objects.get(prefix=prefix)
      vlangroup=VLANGroup.objects.get(id=3)
      vlansite=Site.objects.get(id=vlangroup.scope_id)
      addtags=[]
      for tag in data['env_tags']:
        addtags.append(tag.id)

      newvid=self.getnextfreevlan(vlangroup.id,51,2500)
      if newvid == None:
         self.log_failure(f"Unable to select a free vlan in the 1500-2500 range")
      else:
         vlanname = f"CUST-{name}-{newvid}"
         newvlan = VLAN(
            vid = newvid,
            name = vlanname,
            group = vlangroup,
            site = vlansite
         )
         newvlan.save()
         for tag in data['env_tags']:
            newvlan.tags.add(tag.name)
         self.log_success(f"Vlan Selected : [{vlanname} ({newvid})](/ipam/vlans/{newvlan.id}/)")

But wondering if this is a 'bug' or not.. The fact that the site id is not present, causing the available vlans to become incorrect.

Pieter

[jeremystretch]

In order for this to be triaged as a bug, you'll need to provide specific steps that someone can take to reproduce the reported behavior using the UI or REST API. If you need assistance with your script, please close this issue and open a discussion instead.

[PieterL75]

Jeremy,

I was able to reproduce this in the https://demo.netbox.dev/ instance.
Steps

• Wait for a clean of https://demo.netbox.dev/
• Go to VLAN Group JBB109 (https://demo.netbox.dev/ipam/vlan-groups/3/)
• Hit '+ Add Vlan' button (https://demo.netbox.dev/ipam/vlans/add/?group=3)
  ID: 190
  Name: testing190
  Leave other values default
• Go to the Vlan Group details (https://demo.netbox.dev/ipam/vlan-groups/3/)
• Now you will see that there are 200 Vlans available BEFORE vlanid 190; and 3904 VLANs available betweenvid 190 and 201
  

This happens when a VLAN is added without a 'Site' value.
When setting the 'Site' to "Virginia / JBB Branch 109", the numbers are calculated correct.

Another thing I noted, the 'xx VLANs Available' used to be a clickable button but is regular text now.

I hope this satisfies a valid bugreport

Thank you for the support

Pieter

[jeremystretch]

Looks like this stems from a tweak to the VLAN ordering. Should be a simple fix.

Another thing I noted, the 'xx VLANs Available' used to be a clickable button but is regular text now.

This was addressed under #6308 and will be fixed in v2.11.3.