-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Closed
Labels
status: acceptedThis issue has been accepted for implementationThis issue has been accepted for implementationtype: featureIntroduction of new functionality to the applicationIntroduction of new functionality to the application
Description
NetBox version
v.2.10.8
Feature type
Change to existing functionality
Proposed functionality
Allow setting ssl_cert_reqs=None on the redis client used for Cacheops and Django-RQ.
Use case
This is required for using the Heroku-provided Redis instances with Netbox. They force you to use TLS, but don't provide proper certificates. See https://devcenter.heroku.com/articles/heroku-redis#connecting-in-python
Database changes
No response
External dependencies
No response
This is how it could be implemented:
For Django-RQ the option is available as SSL_CERT_REQS on the config dict (code change)
For Django-Cacheops it seems switching from an url to a kwargs dict for redis-py would suffice: https://github.com/Suor/django-cacheops/blob/master/cacheops/redis.py#L103-L107
e.g. changing the config block in settings.py to
CACHEOPS_REDIS = {
'host': CACHING_REDIS_HOST,
'port': CACHING_REDIS_PORT,
'password': CACHING_REDIS_PASSWORD,
'ssl': CACHING_REDIS_SSL,
'ssl_cert_reqs': CACHING_REDIS_VERIFY_CERT ? 'required' : None,
}
Metadata
Metadata
Assignees
Labels
status: acceptedThis issue has been accepted for implementationThis issue has been accepted for implementationtype: featureIntroduction of new functionality to the applicationIntroduction of new functionality to the application