Allow customization of job timeout for scripts

[DanSheps]

Environment

• Python version: 3.6.6
• NetBox version: 2.10.1

Proposed Functionality

• Add JOB_TIMEOUT to Script base class
• Add job_timeout=Script.JOB_TIMEOUT to enqueue_job kwarg (per docs, this is popped out on job start)

Use Case

With the move towards background job processing, the time constraint on scripts is no longer as restrictive. I feel allowing customization of the job_timeout per-script would be beneficial (if a job times out, the job is still also listed as "Running", this should be handled separately as a bug)

Database Changes

None

External Dependencies

None

[jeremystretch]

Add JOB_TIMEOUT to Script base class

Should this be a Meta attribute?

[DanSheps]

I think making it a Meta attribute would be reasonable.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Please see our contributing guide.

[DanSheps]

I am going to take a crack at this sometime this month. Just been a busy month so far.

[DanSheps]

This will likely need a re-implementation of the @job decorator, most of it can be superclassed but delay might need to be re-worked (at least a little).

Thoughts @jeremystretch?

[DanSheps]

Going to work on this after 3.1 is released

[IdRatherStand]

For anyone interested in extending the script timeout prior to this FR being implemented, you need to modify the job decorator in scripts.py to specify a timeout:

@job('default',timeout=XXX)

Currently this is found here:

netbox/netbox/extras/scripts.py

Line 404 in 4b81d86

@job('default')

I'm sure this isn't an approved method or supported by any means however it sorted our use case where we needed around 7 minutes execution time. I'm afraid I don't have the python / django knowledge to raise a PR for this to be implemented properly.