-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Closed
Labels
status: acceptedThis issue has been accepted for implementationThis issue has been accepted for implementationtype: deprecationRemoval of existing functionality or behaviorRemoval of existing functionality or behavior
Milestone
Description
Proposed Changes
#4262 introduced support for an optional commit argument in a custom script's run() method. This issue serves to document the deprecation of this as an optional argument: Beginning with v2.10, a custom script's run() method must accept a commit argument.
Justification
Removes superfluous backward-compatibility logic from core. A custom script doesn't necessarily need to do anything with the commit argument; it just needs to accept it when called via run_script().
Metadata
Metadata
Assignees
Labels
status: acceptedThis issue has been accepted for implementationThis issue has been accepted for implementationtype: deprecationRemoval of existing functionality or behaviorRemoval of existing functionality or behavior