Skip to content

Require 'commit' argument in custom script run() method #4941

@jeremystretch

Description

@jeremystretch

Proposed Changes

#4262 introduced support for an optional commit argument in a custom script's run() method. This issue serves to document the deprecation of this as an optional argument: Beginning with v2.10, a custom script's run() method must accept a commit argument.

Justification

Removes superfluous backward-compatibility logic from core. A custom script doesn't necessarily need to do anything with the commit argument; it just needs to accept it when called via run_script().

Metadata

Metadata

Assignees

No one assigned

    Labels

    status: acceptedThis issue has been accepted for implementationtype: deprecationRemoval of existing functionality or behavior

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions