No entry point exists to mark a background job as failed

[jeremystretch]

Deployment Type

Self-hosted

NetBox Version

v4.3.3

Python Version

3.10

Steps to Reproduce

This issue concerns the current implementation of JobRunner, specifically the way the run() method of a job is executed:

netbox/netbox/netbox/jobs.py

Lines 77 to 79 in ea4c205

	job.start()
	cls(job).run(*args, **kwargs)
	job.terminate()

Expected Behavior

Setting the status of a job to "failed" (STATUS_FAILED) within the run() method should mark the completed job as failed.

Observed Behavior

The job's status is overwritten with the default "completed" status so long as no exceptions are raised within run(). This is because the terminate() method, called immediately after run(), sets the job's status to "completed" by default.