The function of selecting all devices fails.

[Wythetells]

Deployment Type

Self-hosted

NetBox Version

v4.2.5

Python Version

3.11

Steps to Reproduce

1、Select all the devices (25 in total) on the current page in the device list.

2、Select the option "Select all 43 devices matching query". and edit

3、Edit the comments and click "Apply".

4、Only 25 devices are updated.

Expected Behavior

all 43 devices are updated.

Observed Behavior

Only 25 devices are updated.

[bctiemann]

Verified this. Note for reproduction: set page size to 25 in user preferences, and select filters that result in > 25 results.

[antoinekh]

I’ll be happy to take this issue

[antoinekh]

This is not related to devices only but global (IPAdress, Cable, Prefix...)

Same behavior with IPaddress for example :

Edit show all devices but at the end only the devices limit from the page size are updated

[jeremystretch]

@antoinekh assigned to you, thanks

[antoinekh]

This issue is on all models (not only devices)

Same issue on the past:
#17963

Fix by @jeremystretch on #17994

Issue seems to have been reinsert here: #18197 to handle the HTMXSelect

Where the else condition disappears

I have readded the last else condition and this fix back the issue

        else:
            form = self.form(initial=initial_data)
            restrict_form_fields(form, request.user)

I'm not sure if this is the way to fix it cleanly, but I've tested it, it works and I don't see any problems.