Skip to content

Incorrect Icon for base Github authentication in login form #18926

@jnovinger

Description

@jnovinger

Deployment Type

Self-hosted

NetBox Version

v4.2.5

Python Version

3.10

Steps to Reproduce

Strictly speaking, only steps 1 and 6 below are required to demonstrate the bug. Steps 2-5 ensure that the GitHub auth backend is configured correctly.

  1. Set the following netbox/netbox/configuration.py
REMOTE_AUTH_BACKEND = [
    'netbox.authentication.RemoteUserBackend',
    'social_core.backends.github.GithubOAuth2',
]
  1. Follow Python Social Auth's steps for setting base GitHub authentication: https://python-social-auth.readthedocs.io/en/latest/backends/github.html

Note: when entering the 'Authorization Callback URL' in the Github application, use <scheme>://<domain>/oauth/complete/github/ rather than <scheme>://<domain>/complete/github/.

  1. Set SOCIAL_AUTH_GITHUB_KEY and SOCIAL_AUTH_GITHUB_SECRET in configuration.py
  2. Restart app (if not running ./manage.py runserver
  3. Navigate to http://127.0.0.1:8000/login/ (or /login/ on your installation)
  4. Observe Docker project icon next to 'GitHub' login button

Expected Behavior

GitHub icon shows up next to 'GitHub' login button

Observed Behavior

Docker project icon next to 'GitHub' login button

Image

Metadata

Metadata

Assignees

Labels

severity: lowDoes not significantly disrupt application functionality, or a workaround is availablestatus: acceptedThis issue has been accepted for implementationtype: bugA confirmed report of unexpected behavior in the application

Type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions