JSON serializer issue for Protection Rules defined in configuration.py

[atownson]

Deployment Type

Self-hosted

Triage priority

N/A

NetBox Version

v4.1.11

Python Version

3.12

Steps to Reproduce

1. Create a custom Protection_Rule in the configuration.py. Example:

from extras.validators import CustomValidator

# Prevent IP addresses from being deleted by a cascading delete
class IpAddressProtectionRule(CustomValidator):
    def validate(self, instance, request):
        if hasattr(instance, 'primary_ip') and instance.primary_ip is not None:
            self.fail('This instance has a related IP address(es).')


PROTECTION_RULES = {
    'dcim.device': (
        IpAddressProtectionRule(),
    ),
}

2. Restart NetBox services
3. Navigate to Admin -> System

Expected Behavior

The system detail page is returned.

Observed Behavior

An exception is thrown:

[atownson]

I believe the fix for this is to update netbox/netbox/tempates/core/inc/config_data.html as follows:
Current:

...
  <tr>
    <th scope="row" class="border-0 ps-3">{% trans "Protection rules" %}</th>
    {% if config.PROTECTION_RULES %}
      <td class="border-0"><pre>{{ config.PROTECTION_RULES|json }}</pre></td>
    {% else %}
      <td class="border-0">{{ ''|placeholder }}</td>
    {% endif %}
  </tr>
...

Proposed change:

...
  <tr>
    <th scope="row" class="border-0 ps-3">{% trans "Protection rules" %}</th>
    {% if config.PROTECTION_RULES %}
      <td class="border-0"><pre>{{ config.PROTECTION_RULES }}</pre></td>
    {% else %}
      <td class="border-0">{{ ''|placeholder }}</td>
    {% endif %}
  </tr>
...

This will match the CUSTOM_VALIDATORS block above it. I can submit a PR for this if approved.

[jeremystretch]

Thanks @atownson, I've assigned this to you.