Upgrade script installs venv in wrong directory if pwd-returned directory contains spaces

[prryplatypus]

Deployment Type

Self-hosted

NetBox Version

v2.9.1

Python Version

3.11

Steps to Reproduce

1. Clone netbox into a directory with spaces (e.g.: ~/Documents/Some Folder/Repos/netbox)
2. Follow the installation instructions

Expected Behavior

The upgrade.sh script creates the venv in ~/Documents/Some Folder/Repos/netbox/venv and completes successfully.

Observed Behavior

The upgrade.sh script creates the venv in ~/Documents/Some and the script fails.

[prryplatypus]

Small snippet that might be useful for escaping spaces: printf "%q/venv\n" "$(pwd -P)"

[RangerRick]

it's actually being called in an eval so it needs double-quoting... should be able to quote anywhere eval is called, and then also quote any arguments inside that are dynamic, eg, replace:

# Create a new virtual environment
COMMAND="${PYTHON} -m venv ${VIRTUALENV}"
echo "Creating a new virtual environment at ${VIRTUALENV}..."
eval $COMMAND || {

...with:

# Create a new virtual environment
COMMAND="${PYTHON} -m venv \"${VIRTUALENV}\""
echo "Creating a new virtual environment at ${VIRTUALENV}..."
eval "$COMMAND" || {

Might be worth adding shellcheck to the CI/CD pipeline to catch stuff like this.

[prryplatypus]

I can open a PR to fix this later today

[jeremystretch]

Thanks @prryplatypus, I've assigned this to you.