Relax requirement for IKE policy

[m2martin]

Deployment Type

Self-hosted

NetBox Version

v3.7.1

Python Version

3.9

Steps to Reproduce

1. Go to IKE policies and add a policy
2. Field Mode is required and provides Aggressive and Main

Expected Behavior

Field Mode is not required.

Observed Behavior

Field Mode is required.

[m2martin]

Background:

One of the substential differences between IKEv1 and IKEv2 is the initial message exchange which has no configurable modes (Main/Aggressive) compared to v1.

The field Mode should not be required like Authentication algo in IKE proposals which depends on the encryption algo (CBC/GCM) (see #14499).

...yes I know...blank=True would need a migration.

[DanSheps]

If someone wants to tackle this, the best way forward would be:

• set blank=True and null=True on the model (build the migration as well
• Edit the model clean method to require IKEv1 to have a mode of any of the choices

[m2martin]

If the change is basically accepted, I'd implement it accordingly.

[DanSheps]

If the change is basically accepted, I'd implement it accordingly.

All you @m2martin