Service Creation Comments Issue

[abahney]

NetBox version

v3.6.1

Python version

3.10

Steps to Reproduce

1. Go to Services
2. Add Service
3. Select a Device
4. Select Custom (or template)
5. Input Details

Name: Test
Protocol: TCP
Ports: 443
Comments: Anything

6. Click Create

Expected Behavior

Service to be created with the comments included.

Observed Behavior

The comments section is blank and also shows nothing in the change log.

Workaround: Edit the service after creation and input the comment.

[abhi1693]

Thank you for opening a bug report. It seems that the described functionality is intended behavior. If you meant to open a feature request instead, please close this issue and open a new one using the feature request template. Otherwise, please revise your post above to elaborate on why you believe the observed behavior is flawed.

[abahney]

I guess I'm confused as to why the Comments section exists during creating a service?

[abhi1693]

I'm sorry I misunderstood the issue.

[abahney]

That's alright, I should of included the screenshots in the original post. I don't know much about the code, but it looks like it could have something to do with this.

netbox/netbox/ipam/forms/model_forms.py

Lines 724 to 756 in 6939bf8

	class ServiceCreateForm(ServiceForm):
	service_template = DynamicModelChoiceField(
	label=_('Service template'),
	queryset=ServiceTemplate.objects.all(),
	required=False
	)
	class Meta(ServiceForm.Meta):
	fields = [
	'device', 'virtual_machine', 'service_template', 'name', 'protocol', 'ports', 'ipaddresses', 'description',
	'tags',
	]
	def __init__(self, *args, **kwargs):
	super().__init__(*args, **kwargs)
	# Fields which may be populated from a ServiceTemplate are not required
	for field in ('name', 'protocol', 'ports'):
	self.fields[field].required = False
	del self.fields[field].widget.attrs['required']
	def clean(self):
	super().clean()
	if self.cleaned_data['service_template']:
	# Create a new Service from the specified template
	service_template = self.cleaned_data['service_template']
	self.cleaned_data['name'] = service_template.name
	self.cleaned_data['protocol'] = service_template.protocol
	self.cleaned_data['ports'] = service_template.ports
	if not self.cleaned_data['description']:
	self.cleaned_data['description'] = service_template.description
	elif not all(self.cleaned_data[f] for f in ('name', 'protocol', 'ports')):
	raise forms.ValidationError("Must specify name, protocol, and port(s) if not using a service template.")

[jeremystretch]

Thanks @abahney; you're correct about the form. The comments field is erroneously omitted from the form's field list.