-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Closed as not planned
Labels
pending closureRequires immediate attention to avoid being closed for inactivityRequires immediate attention to avoid being closed for inactivitystatus: under reviewFurther discussion is needed to determine this issue's scope and/or implementationFurther discussion is needed to determine this issue's scope and/or implementationtopic: UI/UXUser interface or user experience related workUser interface or user experience related worktype: featureIntroduction of new functionality to the applicationIntroduction of new functionality to the application
Description
NetBox version
v3.5.6
Feature type
Change to existing functionality
Proposed functionality
Currently the background color of an interface is like this :
disabled: red
virtual: blue
enabled, marked_connected: green
enabled, connected (cable status color) : green/blue/..
enabled, no cable : white
def get_cabletermination_row_class(record):
if record.mark_connected:
return 'success'
elif record.cable:
return record.cable.get_status_color()
return ''
def get_interface_row_class(record):
if not record.enabled:
return 'danger'
elif record.is_virtual:
return 'primary'
return get_cabletermination_row_class(record)
My proposal is to change the color coding to:
disabled: white
virtual: blue
enabled, marked_connected: green
enabled, connected (cable status color) : green/blue/...
enabled, no cable : red
def get_cabletermination_row_class(record):
if record.mark_connected:
return 'success'
elif record.cable:
return record.cable.get_status_color()
return 'danger'
def get_interface_row_class(record):
if not record.enabled:
return ''
elif record.is_virtual:
return 'primary'
return get_cabletermination_row_class(record)
Use case
The 'red' color is confusing, as it tells me something is 'wrong'. but having an interface in the disable state is not wrong.
Having an 'enabled' interface, without a cable is 'danger'
A disabled interface is just good, that can be white.
Database changes
No response
External dependencies
No response
jose-d
Metadata
Metadata
Assignees
Labels
pending closureRequires immediate attention to avoid being closed for inactivityRequires immediate attention to avoid being closed for inactivitystatus: under reviewFurther discussion is needed to determine this issue's scope and/or implementationFurther discussion is needed to determine this issue's scope and/or implementationtopic: UI/UXUser interface or user experience related workUser interface or user experience related worktype: featureIntroduction of new functionality to the applicationIntroduction of new functionality to the application