Script ignores 'scheduling_enabled' if it has no input parameters

[candlerb]

NetBox version

v3.5.4

Python version

3.8

Steps to Reproduce

Upload the following script and run it:

from extras.scripts import Script

class TestScript(Script):
    class Meta:
        name = "Test Script"
        scheduling_enabled = False

    def run(self, data, commit):
        self.log_success("Run OK")
        return "OK\n"

Expected Behavior

Since scheduling_enabled is False, Netbox should not offer to run the script at scheduled times.

Observed Behavior

Note however that commit_default = False is honoured if provided.

[kkthxbye-code]

Lots of stuff wrong here. To add to the description, it's important to note that if the script has input, the scheduling fields are removed.

The reason they are not getting removed if there is input is because the logic here is wrong:

netbox/netbox/templates/extras/script.html

Lines 18 to 38 in 07ae7c8

	{% if form.requires_input %}
	{# Render grouped fields according to declared fieldsets #}
	{% for group, fields in script.get_fieldsets %}
	<div class="field-group mb-5">
	<div class="row mb-2">
	<h5 class="offset-sm-3">{{ group }}</h5>
	</div>
	{% for name in fields %}
	{% with field=form|getfield:name %}
	{% render_field field %}
	{% endwith %}
	{% endfor %}
	</div>
	{% endfor %}
	{% else %}
	<div class="alert alert-info">
	<i class="mdi mdi-information"></i>
	This script does not require any input to run.
	</div>
	{% render_form form %}
	{% endif %}

The scheduling fields are removed in the get_fieldsets() method, which is only called if form.requires_input is True (L18). If the form doesn't require input the entire form is just rendered.

Now even if that is fixed, the check to prevent scripts from being scheduled is not working either.

The ScriptForm is never passed the scheduling_enabled parameter:

netbox/netbox/extras/scripts.py

Line 388 in 07ae7c8

form = FormClass(data, files, initial=initial)

The ScriptForm init method:

netbox/netbox/extras/forms/scripts.py

Lines 37 to 47 in 07ae7c8

	def __init__(self, *args, scheduling_enabled=True, **kwargs):
	super().__init__(*args, **kwargs)
	# Annotate the current system time for reference
	now = local_now().strftime('%Y-%m-%d %H:%M:%S')
	self.fields['_schedule_at'].help_text += f' (current time: <strong>{now}</strong>)'
	# Remove scheduling fields if scheduling is disabled
	if not scheduling_enabled:
	self.fields.pop('_schedule_at')
	self.fields.pop('_interval')

Now if the form is fixed and scheduling_enabled is passed to the form, an exception will be thrown here because the previous code pop'ed them already:

netbox/netbox/extras/views.py

Line 1087 in 07ae7c8

schedule_at=form.cleaned_data.pop('_schedule_at'),

Open for volunteers.