Jinja2 condition not working anymore in Custom Link URL field

[tux-mania]

NetBox version

v3.5.2

Python version

3.9

Steps to Reproduce

1. Create a custom link with jinja2 condition in "Link URL" field. For example, I set a new Custom Link named "website" with the following on the Link URL field:

{% if object.tenant_id == 1 %}
https://www.google.com
{% else %}
https://www.duckduckgo.com
{% endif %}

Expected Behavior

According to my object tenant id, it should open a webpage on google.com or duduckgo.com when clicking on the custom link button.

Observed Behavior

Instead, I got the following error:

This behaviour seems related to the feature "Sanitize rendered custom link HTML" #12205 .
In fact, when removing the code added in the commit 89fa546, the expected behavior happens.

Thank you for your help.

[jeremystretch]

The issue is that the rendered template produces errant line breaks before and after the URL (the %0A characters). We can tweak the code to tweak leading & trailing whitespace from the rendered template, but in the meantime I suggest altering your Jinja code to do this natively by adding hyphens to the block markers:

{% if object.tenant_id == 1 -%}
https://www.google.com
{%- else -%}
https://www.duckduckgo.com
{%- endif %}

[tux-mania]

Hello @jeremystretch !
I didn't know about the hyphens. Works perfectly fine with this modification.
Thank you very much!

[jeremystretch]

Glad that worked out, but I'd still like to strip whitespace from the rendered template to help avoid this issue.