Reindex command does not accept app_label as argument

[Alef-Burzmali]

NetBox version

v3.4.1

Python version

3.10

Steps to Reproduce

1. Look at the help of the reindex management command: it accepts app_label[.ModelName]

$ python /opt/netbox/netbox/manage.py reindex -h
[...]
positional arguments:
  app_label[.ModelName]
                        One or more apps or models to reindex

2. Reindex all models of a plugin or an app:

$ python /opt/netbox/netbox/manage.py reindex dcim
CommandError: Invalid model: dcim. Model names must be in the format <app_label>.<model_name>.

The use case is reindexing all the models of a plugin after adding SearchIndex for my models.

Expected Behavior

The command reindexes all the the models of the plugin/app corresponding to app_label.

Observed Behavior

CommandError: Invalid model: dcim. Model names must be in the format <app_label>.<model_name>.

The current code does not allow selecting all the models of an app. registry['search'] could be iterated to find all the models of the app if there is no dot in model_names, or simpler, the args of the command could be updated to remove that possibility.

netbox/netbox/extras/management/commands/reindex.py

Lines 29 to 40 in 3675ad2

	for label in model_names:
	try:
	app_label, model_name = label.lower().split('.')
	except ValueError:
	raise CommandError(
	f"Invalid model: {label}. Model names must be in the format <app_label>.<model_name>."
	)
	try:
	idx = registry['search'][f'{app_label}.{model_name}']
	indexers[idx.model] = idx
	except KeyError:
	raise CommandError(f"No indexer registered for {label}")

[Alef-Burzmali]

Thanks for accepting the bug. Would you please assign it to me so I can make a PR?

I think it can be used to address #11248 too, if the migration extras.0083_search is modified to reindex only the apps of NetBox core. Then, plugin authors will have to add a small migration like 0083_search for their own models, but I guess it will always be required when new SearchIndexes are added. Please let me know if I should tackle that one too.

[kkthxbye-code]

@Alef-Burzmali - All yours