[WIP] Replace "go-swagger" by "oapi-codegen" #161
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
v0ctor
force-pushed
the
feature/oapi-codegen
branch
from
cd281fd to
de0b09d
Compare
v0ctor
force-pushed
the
feature/oapi-codegen
branch
from
de0b09d to
cc909b7
Compare
|
Hello, any update on this PR? |
|
any updates on this one? |
Collaborator
Author
|
Closing, since "openapi-generation" has been chosen as the final option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since version 3.5, Netbox specifies its API with OpenAPI 3. Thus, it is no longer possible to keep this project up to date, as it is generated using go-swagger, a library that doesn't support OpenAPI 3 and has no intention to do so.
This PR replaces go-swagger by oapi-codegen and rebuilds the library for the latest version of Netbox (3.6.3). This change is completely incompatible with previous versions of the library. This is an alternative option to PR #157.
Note that this is a work in progress. I still didn't test the changes.
Any comments, suggestions or corrections are welcome! Furthermore, everyone is invited to participate in the OpenAPI 3 migration discussion.