Skip to content

Conversation

@bastianleicht
Copy link
Contributor

@bastianleicht bastianleicht commented Apr 18, 2025

As described in #2618

Implementation of the importer in: netbox-community/Device-Type-Library-Import#170

Copilot AI review requested due to automatic review settings April 18, 2025 13:36
@bastianleicht bastianleicht changed the title Add rack-ypes Add rack-types Apr 18, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new rack type definition for a Startech rack and updates the front image setting for an HPE device type, addressing issue #2618 and supporting the related Device-Type-Library-Import PR.

  • Added a new YAML file for the Startech 4 Post 42U rack with key specifications.
  • Updated the HPE OfficeConnect device type to set front_image to true.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
rack-types/Startech/startech-4postrack42.yaml Introduces a new rack type with specifications and includes commented alternatives for mounting depth and weight.
device-types/HPE/OfficeConnect-1920-24G-PoE-180W.yml Changes the front_image property from false to true.
Comments suppressed due to low confidence (1)

device-types/HPE/OfficeConnect-1920-24G-PoE-180W.yml:8

  • Verify that setting front_image to true is the intended change, and if so, ensure that associated tests and documentation reflect this update.
front_image: true

@harryajc
Copy link
Collaborator

Hi @bastianleicht Thanks for the contribution,
We also need to add the pre commit checks for the rack device types.

@bastianleicht
Copy link
Contributor Author

@harryajc The Pre-Commit Checks should already work? As far as I know, they are not limited to folders etc.

Or am I wrong here?

@danner26
Copy link
Member

What Harry is mentioning is adding a new data type means we will need to build out the schemas and test cases. Also, the schema generation in NetBox proper will need to be updated to gather the variable details like we do with the device and module types

@bastianleicht
Copy link
Contributor Author

@danner26 Right, I forgot that. I just added the Schema and Schema generation. It worked on my side. Do i need to add anything more?

@bastianleicht
Copy link
Contributor Author

Okay, I think I now got everything. The Pytest is now working correctly and checking the files.

@harryajc harryajc requested a review from danner26 May 29, 2025 10:52
@bastianleicht
Copy link
Contributor Author

Hey, when is this getting merged?

@harryajc
Copy link
Collaborator

Hi @bastianleicht,

I was waiting for @danner26 to give a review and check he was happy with this change.

Copy link
Collaborator

@harryajc harryajc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it would be good to add some info about rack types into the README

@bastianleicht
Copy link
Contributor Author

I just updated the readme with the rack-types documentation. Is it now all clear?

@harryajc harryajc merged commit 57742db into netbox-community:master Aug 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants