Skip to content

Conversation

@getspaghett
Copy link
Contributor

I created the .yaml file for the Intel blade with the Specs from the Intel Spec sheet. I thought about adding the PCIe slots as module bays but i was not sure if this is the intended way to model this kind of data inside NetBox. Please let me know how i can improve my contributions.

@getspaghett getspaghett marked this pull request as ready for review March 8, 2023 09:17
@danner26
Copy link
Member

danner26 commented Mar 8, 2023

So for the PCIe slots, can they be used for NIC cards? If so, then yes they are 100% valid as module-bays

That being said, NetBox does not yet support storage management, but it is on the roadmap.

@danner26 danner26 added the status: revisions needed This issue requires additional information to be actionable label Mar 8, 2023
@getspaghett getspaghett requested a review from danner26 March 9, 2023 15:42
@danner26
Copy link
Member

danner26 commented Mar 9, 2023

Hello, unfortunately today we had to make a change to the schema in which weight is defined by. The upstream NetBox API requires weight to be passed to it in the following format:

weight: 12.01
weight_unit: lb

Due to this change, I have updated your branch against the current master. This might require you to update your PR, if you had weight currently defined, so that your PR is in-line with the new weight schema. If you have any issues, please let me know or refer to this PR for more information.

@danner26
Copy link
Member

danner26 commented Mar 9, 2023

Does this PR need anything else?

@getspaghett
Copy link
Contributor Author

getspaghett commented Mar 10, 2023

Does this PR need anything else?

No, i think i added everything that is attached to the chassis and it is ready to be merged 👍

@danner26 danner26 added status: accepted and removed status: revisions needed This issue requires additional information to be actionable labels Mar 10, 2023
@danner26 danner26 merged commit ccc4447 into netbox-community:master Mar 10, 2023
etherwrangler pushed a commit to etherwrangler/devicetype-library that referenced this pull request Jul 16, 2023
* pre-commit fixed eof new line

* fixed child weight, added module-bays for pcie riser and added QSFP+ interface

* fixed weight and module-bays positions

---------

Co-authored-by: Daniel W. Anner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants