Added Intel H2312XXLR2 blade system #1177
Conversation
|
Sorry, i think i have changed this from a draft to a pull request too soon. :( |
|
found out how to change it back to draft |
deleted my changed .gitignore
…icetype-library into Intel-H2312XXLR2
|
i am sorry but i do not have enough git skills yet to remove my .gitignore from this branch ... |
added new line at end of file
|
ok i think i figured it out, the gitignore is no longer in this branch ... sorry for the messy commits |
|
Its great seeing you move through the issues and overcome them :) I will work on reviewing this soon. Thanks in advance for your contribution! |
danner26
added
the
status: revisions needed
|
Do the PSU modules already exist? If so then just the one last correction, otherwise please add the applicable PSU modules to this PR :) |
|
Hello, unfortunately today we had to make a change to the schema in which weight is defined by. The upstream NetBox API requires weight to be passed to it in the following format: Due to this change, I have updated your branch against the current master. This might require you to update your PR, if you had weight currently defined, so that your PR is in-line with the new weight schema. If you have any issues, please let me know or refer to this PR for more information. |
…icetype-library into Intel-H2312XXLR2
Fixed position reference
|
My bad, I forgot to tell you to put |
Fix power-ports reference
fix power-ports definition
danner26
added
status: accepted
and removed
status: revisions needed
|
Thank you for the fixes :) |
* ignore my custom venv dir * Created definition for Intel H2312XXLR2 * changed power-ports type to iec-60320-c22 * Delete .gitignore deleted my changed .gitignore * restored original .gitignore * Update .gitignore added new line at end of file * changed power ports type to iec-60320-c14 * added weight, airflow and changed power-ports to module bays * removed comment * created module-types for intel 1600w and 2130w redundant power supplies * changed weight to fit new schema and changed position on module-bays * fixed PSU module name to reflect position in device * Update H2312XXLR2.yaml Fixed position reference * Update FXX1600PCRPS.yaml Fix power-ports reference * Update FXX2130PCRPS.yaml fix power-ports definition --------- Co-authored-by: Daniel W. Anner <[email protected]>
2 participants
Created definitions for Intel H2312XXLR2 blade system.
Specifications taken from Intel.com