Update MikroTik devices

[ZoLuSs]

Update MikroTik devices that is not compliant with bulk import function by adding u_height and add is_full_depth info.

[danner26]

Are these devices actually half of a rack unit?? If these are not rack mountable, then they should be marked as u_height: 0

[ZoLuSs]

Yeah they are half rack for some of them. I change that quickly !

[danner26]

So they are rack mountable and only take up .5 U's? 1U is 1.75 inches or 3 mounting holes. So how many mounting holes does the racked device take up? I am confused by this to be honest

[danner26]

RB2011UiAS-IN is listed as wall mountable, not rack mountable. So this should be u_height: 0

[ZoLuSs]

Mikrotik is really complicated for this...
For example, RB5009 can be rack mounted with RB5009 rackmount kit K-79. But the adapter can fit 4 RB5009 in 1U.
So, should I make RB5009 1U, should they be 0U since by default it's no rack mountable or should I create the rack adapter (for stacking multiple devices) with 1U as parent and device as child with 0U.

What do you think of this:
No rack adapter include: 0U
Rack adapter for stacking multiple device in 1U: 0U and I create the rack adapter as parent with 1U and device as child.
Rack adapter included or Rack mountable: 1U

[danner26]

Alright so I talked with the internal maintainers. We are in agreement the rack adapter should be created as its own 1U device marked as a parent, with 4 device bays
Then the devices should be created with u_height: 0 and defined as child devices

[danner26]

@ZoLuSs when you complete working on this, please let me know. In the meantime I am marking this as a draft PR

[danner26]

Hello, unfortunately today we had to make a change to the schema in which weight is defined by. The upstream NetBox API requires weight to be passed to it in the following format:

weight: 12.01
weight_unit: lb

Due to this change, I have updated your branch against the current master. This might require you to update your PR, if you had weight currently defined, so that your PR is in-line with the new weight schema. If you have any issues, please let me know or refer to this PR for more information.

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further progress is made.

[ZoLuSs]

Hey @danner26 can you help me ?
On my computer I run 'pre-commit run --all' but all the error are related to other file (that I don't have touch):

- hook id: yamllint
- exit code: 1

module-types/Eaton/EMPDT1H1C2.yaml:5:47: [error] trailing spaces (trailing-spaces)
device-types/Eaton/9PXEBM180.yaml:9:28: [error] trailing spaces (trailing-spaces)
device-types/Eaton/9PX3000iRT2U.yaml:9:28: [error] trailing spaces (trailing-spaces)
device-types/ZTE/C300.yaml:9:79: [error] trailing spaces (trailing-spaces)
module-types/Eaton/Network-M2.yaml:5:31: [error] trailing spaces (trailing-spaces)
device-types/Eaton/9PXEBM72RT2U.yaml:9:28: [error] trailing spaces (trailing-spaces)
device-types/Dell/DMPU2016-G01.yml:9:31: [error] trailing spaces (trailing-spaces)
device-types/Adtran/TA-5000-23in.yaml:9:114: [error] trailing spaces (trailing-spaces)
device-types/Eaton/9PX5KIRTN.yaml:7:55: [error] trailing spaces (trailing-spaces)

So my PR is correct but failed to pass check because of the others files. Am I wrong ?
Can this PR be merge ?

[danner26]

Hey @ZoLuSs I just pulled the master branch and ran pre-commit without issue. Are you sure you created your branch off of the latest master?
I am seeing this now too, let me see what I can do

[danner26]

I believe I have fixed the issue now, sorry about that!

[danner26]

It appears to be CCR1009-8G-1S-1S+.yaml which is causing the error. Line 6/7 is the specific problem. Since the string is so long it wants it cut down. I fixed the issue for you

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further progress is made.

[github-actions]

This PR has been automatically closed due to lack of activity.