Skip to content

Conversation

@rogeriomendesp
Copy link
Contributor

No description provided.

@rogeriomendesp
Copy link
Contributor Author

Hi, help.

I have this equipment to add https://www.datacom.com.br/en/produtos/gpon/dm4618 , but it has a slot, this slot cryo device bay or module bay?

What about the board, do I create it as a child device type and the chassis as a parent?
https://www.datacom.com.br/uploads/product/file/78e9b89bab08dcd67045f3e3f4d4c9ae.pdf

@rogeriomendesp
Copy link
Contributor Author

Hi,

I would like a status of this request.

Thanks.

@rogeriomendesp
Copy link
Contributor Author

Hi,

I would like a status of this request.

Thanks.

@danner26
Copy link
Member

danner26 commented May 8, 2023

Hello, have you made the requested updates yet? Also, please ensure all checks are passing.

Once you are ready for this to be reviewed, please mark this PR ready for review (it is currently in a draft status).

@rogeriomendesp rogeriomendesp marked this pull request as ready for review May 8, 2023 15:18
Copy link
Member

@danner26 danner26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thanks for this. Some notes about changes that I believe may be applicable to most if not all of your added files

  1. Slugs: all slugs should have the manufacturers name appended. I.E. datacom-
  2. Please add weight and weight_unit to any devices which you can find that information
  3. Please add airflow to any devices which you can find that information

@danner26 danner26 added status: revisions needed This issue requires additional information to be actionable and removed status: under review A Pull Request (PR) or Issue that is current in review by a maintainer labels May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: revisions needed This issue requires additional information to be actionable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants