-
Couldn't load subscription status.
- Fork 1.2k
Adding equipment from the manufacturer DATACOM. #1103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixed slug name to match part name Fixed comment to adhear to pre-commit removed unnessecary interface definitions
Fixed comment formatting
Fixed comment formatting
Fixed comment formatting
Reverted change to the slug
|
Hi, help. I have this equipment to add https://www.datacom.com.br/en/produtos/gpon/dm4618 , but it has a slot, this slot cryo device bay or module bay? What about the board, do I create it as a child device type and the chassis as a parent? |
|
Hi, I would like a status of this request. Thanks. |
|
Hi, I would like a status of this request. Thanks. |
|
Hello, have you made the requested updates yet? Also, please ensure all checks are passing. Once you are ready for this to be reviewed, please mark this PR ready for review (it is currently in a draft status). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thanks for this. Some notes about changes that I believe may be applicable to most if not all of your added files
- Slugs: all slugs should have the manufacturers name appended. I.E.
datacom- - Please add
weightandweight_unitto any devices which you can find that information - Please add
airflowto any devices which you can find that information
No description provided.