Skip to content

Conversation

@danner26
Copy link
Member

Assisting @renaniam with moving this module definition they created to the module-types
Reference is #1055

@danner26
Copy link
Member Author

@renaniam Please review this and make sure it is ready to be merged, I have created it in the module-types folder

@danner26 danner26 mentioned this pull request Jan 18, 2023
@danner26 danner26 added the status: under review A Pull Request (PR) or Issue that is current in review by a maintainer label Jan 18, 2023
@danner26
Copy link
Member Author

@renaniam I fixed the extra variables that do not belong in module-types. Once again though, are the ports actually referred to as 53 and 54? Or is this just the position you have them installed in?

I have named them {module}-port1 and {module}-port2 for the time being. If you could send an output of the config for these interfaces that would work as well

@renaniam
Copy link

@danner26

In case of X460-48T theres 52 GE Ports (48 GE Cooper + 4 GE SFP), but there's others Summit models with less than 48 ports.

Diferentily of others devices, when you put a module there's no slot number, in that Extreme Switch model are just add other interfaces.

So, without module we willl find 52 ports GE, when you put this module will be incriased more 2 interfaces numbered by 53 and 54.

There's a XGM3SB-4sf, in that case will be incriased more 4 ports 53, 54, 55 and 56.

In case of SummitStack Module or SummitStack-v80 Module always be the unreacheable ports as 57 and 58 because is not in interface list.

Thanks for all!

@danner26
Copy link
Member Author

Hm, I am thinking of how to handle this then @renaniam
If you slot this into a device with 24 ports, what happens? Are they still referenced as 53, 54 or are they now 25 and 26? Sorry for the confusion.

@renaniam
Copy link

Unfortunately I'm don't had one to make a test, but I suppose that's correct.

@danner26 danner26 added the help wanted Extra attention is needed label Jan 18, 2023
@danner26
Copy link
Member Author

I dont have a great way to model this then, since they do not have a unique name this is going to be a tough one. I will add the help wanted tag and hopefully someone with one of these modules can give us an example output. For now I will mark this PR as a draft as well

@danner26 danner26 marked this pull request as draft January 18, 2023 19:36
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2023

This PR has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further progress is made.

@github-actions github-actions bot added the stale label Mar 4, 2023
@danner26
Copy link
Member Author

danner26 commented Mar 9, 2023

Hello, unfortunately today we had to make a change to the schema in which weight is defined by. The upstream NetBox API requires weight to be passed to it in the following format:

weight: 12.01
weight_unit: lb

Due to this change, I have updated your branch against the current master. This might require you to update your PR, if you had weight currently defined, so that your PR is in-line with the new weight schema. If you have any issues, please let me know or refer to this PR for more information.

@danner26 danner26 closed this Jul 12, 2023
@danner26 danner26 deleted the XGM3S-2XF branch July 12, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed stale status: under review A Pull Request (PR) or Issue that is current in review by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants