Add Schema Interface Types & Correctly Identify Adapters (AT FS Series) #1024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addition is contingent on [Netbox PR#11377](netbox-community/netbox#11377) being completed first. This will not be merged until that is complete
… will allow us to correctly identify these ports
danner26
added
the
status: under review
Member
Author
|
The upstream PR to add these interfaces is now merged. Once it is released and generally available we will be able to merge this |
danner26
added
status: accepted
and removed
status: under review
etherwrangler
pushed a commit
to etherwrangler/devicetype-library
that referenced
this pull request
Jul 16, 2023
…s) (netbox-community#1024) * Adding 3 new adapter types. 100base-fx, 100base-lfx, and 100base-t1. This addition is contingent on [Netbox PR#11377](netbox-community/netbox#11377) being completed first. This will not be merged until that is complete * Based on the addition of 100base-fx in the upstream netbox repo, this will allow us to correctly identify these ports * updated 100base-fx interface names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addition is contingent on this NetBox Issue #11371 and its subsequent Netbox PR #11377 being completed first. Until that is done, we will leave this in a draft state
Adding the following interface types
Subsequently, we will now be able to identify the Allied Telesis FS2xx series adapters correctly.