Skip to content

Conversation

@mostdaysarebaddays
Copy link

Update so "Devices" also filters on manufacturer, not just model

@candlerb
Copy link
Contributor

I don't think this is necessary, can you explain why you think it is?

Device type is already filtered by manufacturer: the only reason for presenting manufacturer as an input is to reduce the length of the list of device types.

Whilst device types don't have unique names (you can have two device types with the same name from different manufacturers), we're filtering devices by the device_type_id which is unambiguous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants