Skip to content

Conversation

@p-rintz
Copy link
Contributor

@p-rintz p-rintz commented Apr 7, 2024

Related Issue

#1069

New Behavior

Choice Sets are supported as a new model and as an option for custom fields

Proposed Release Note Entry

Adds support for custom field choice sets

Double Check

  • I have read the comments and followed the CONTRIBUTING.md.
  • I have explained my PR according to the information in the comments or in a linked issue.
  • My PR targets the devel branch.

sc68cal
sc68cal previously approved these changes Apr 11, 2024
@sc68cal
Copy link
Contributor

sc68cal commented Apr 11, 2024

LGTM, I'll see if @rodvand also approves, otherwise ping me back in a week and I'll merge

@p-rintz
Copy link
Contributor Author

p-rintz commented Apr 11, 2024

Thanks for the review.

There was a small mistake in the documentation of the choice set module. Ive corrected it.
(and Black was complaining now 😄 )

@rodvand rodvand merged commit 4ceb283 into netbox-community:devel Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants