vlan group option name is 'vlan_group' not 'group' #1138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per line 169 of https://github.com/netbox-community/ansible_modules/blob/devel/plugins/modules/netbox_vlan.py the name of the vlan group option is vlan_group not group
As per line 37 and line 169 the option name for a VLAN group is vlan_group not group.
sc68cal
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#1137
New Behavior
Correct option name for vlan groups in docs. No change to operation.
Contrast to Current Behavior
new behavior is the examples for vlan use the correct option name for vlan groups.
Discussion: Benefits and Drawbacks
The benefit is a microscopic improvement in the documentation examples for creating VLANs
There are no known drawbacks.
Changes to the Documentation
This is a change to the docs, so ...
Proposed Release Note Entry
Corrected VLAN group option name in documentation.
Double Check
develbranch.