Skip to content

Conversation

@gaby
Copy link
Contributor

@gaby gaby commented Nov 25, 2021

Docker improvements:

  • Added .dockerignore file made for Python projects.
  • Cleanup of Dockerfile
  • Upgrade pip before trying to install any dependency.

Improvements to Github Workflows:

  • Added support for building, tagging and pushing an image to ghcr.io
  • Added support for running Docker Builds for Pull Requests.
  • Any pushes to master/main will get tagged as "latest".
  • Support for semver tags.
  • Image will be tagged as: ghcr.io/minitriga/Netbox-Device-Type-Library-Import
  • Docker Image will Only be pushed when a new tag is created or when changes are committed into master/main branch.

TODO:

@gaby gaby changed the title Github Workflow and Docker improvements Support for ghcr.io container registry. Nov 26, 2021
@gaby
Copy link
Contributor Author

gaby commented Nov 29, 2021

@minitriga Friendly bump

@minitriga minitriga merged commit 625bdba into netbox-community:master Dec 1, 2021
@minitriga
Copy link
Collaborator

Thank you @gaby i have merged it and the actions run fine.

@gaby gaby deleted the publish-image branch December 1, 2021 13:02
@gaby
Copy link
Contributor Author

gaby commented Dec 1, 2021

Thanks! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants