fix: error on unambigious powerport when trying to create power outlets #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndom91
changed the title
|
Okay, second commit basically just creates the outlet anyway without linking a powerport when more than one is returned and the template doesn't specify. I'm sure theres a more concise way of doing this though, I'm no python expert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an APC template in the device-type library that would always cause this to fail. The APC AP7721.
Problem is there are two power ports, and the template's power outlets are not assigned to either of them. So the
.get()on https://github.com/minitriga/Netbox-Device-Type-Library-Import/blob/master/nb-dt-import.py#L181 would error because it returned two results instead of one unambiguous one.I currently just wrapped it in a try/except where it spits out an error that it couldn't add that power outlet because its not sure which power port to assign it to.
I noticed in the Netbox UI, however, that power port is not a required field for power outlets. So I want to see if I can get this to work to add the power outlet without assigning a port, therefore the current WIP status.