Skip to content

Add SLUGS option to specify a space-separated list of device_type slug… #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Add SLUGS option to specify a space-separated list of device_type slug… #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8160b6c
Add SLUG option to specify a space-separated list of device_type slug…
Oct 5, 2021
b2c20b2
Merge branch 'master' into master
minitriga Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ NETBOX_TOKEN=
REPO_URL=https://github.com/netbox-community/devicetype-library.git
REPO_BRANCH=master
IGNORE_SSL_ERRORS=False
#SLUGS=c9300-48u isr4431 isr4331
19 changes: 14 additions & 5 deletions nb-dt-import.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import argparse
import os
import settings
import sys


counter = Counter(added=0, updated=0, manufacturer=0)
Expand Down Expand Up @@ -54,7 +55,8 @@ def getFiles(vendors=None):
return files, discoveredVendors


def readYAMl(files):
def readYAMl(files, **kwargs):
slugs = kwargs.get('slugs', None)
deviceTypes = []
manufacturers = []
for file in files:
Expand All @@ -68,6 +70,11 @@ def readYAMl(files):
data['manufacturer'] = {}
data['manufacturer']['name'] = manufacturer
data['manufacturer']['slug'] = slugFormat(manufacturer)

if slugs and data['slug'] not in slugs:
print(f"Skipping {data['model']}")
continue

deviceTypes.append(data)
manufacturers.append(manufacturer)
return deviceTypes
Expand Down Expand Up @@ -388,19 +395,21 @@ def main():

VENDORS = settings.VENDORS
REPO_URL = settings.REPO_URL
REPO_BRANCH = settings.REPO_BRANCH

SLUGS = settings.SLUGS
REPO_BRANCH = settings.REPO_BRANCH

parser = argparse.ArgumentParser(description='Import Netbox Device Types')
parser.add_argument('--vendors', nargs='+', default=VENDORS,
help="List of vendors to import eg. apc cisco")
parser.add_argument('--url', '--git', default=REPO_URL,
help="Git URL with valid Device Type YAML files")
parser.add_argument('--slugs', nargs='+', default=SLUGS,
help="List of device-type slugs to import eg. ap4431 ws-c3850-24t-l")
parser.add_argument('--branch', default=REPO_BRANCH,
help="Git branch to use from repo")
args = parser.parse_args()


try:
if os.path.isdir('./repo'):
print(f"Package devicetype-library is already installed, "
Expand All @@ -421,8 +430,8 @@ def main():


print(str(len(vendors)) + " Vendors Found")
print(str(len(files)) + " Device-Types Found")
deviceTypes = readYAMl(files)
deviceTypes = readYAMl(files, slugs=args.slugs)
print(str(len(deviceTypes)) + " Device-Types Found")
createManufacturers(vendors, nb)
createDeviceTypes(deviceTypes, nb)

Expand Down
4 changes: 4 additions & 0 deletions settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
# optionnally load vendors through a space separated list as env var
VENDORS = os.getenv("VENDORS", "").split()

# optionally load device types through a space separated list as env var
SLUGS = os.getenv("SLUGS", "").split()


MANDATORY_ENV_VARS = ["REPO_URL", "NETBOX_URL", "NETBOX_TOKEN"]

for var in MANDATORY_ENV_VARS:
Expand Down