Increase import speed #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f individual ones
|
Damn has the device library gotten that big?! 😂 |
|
Either that or I have terrible internet! I imagine you could have it cache each type of import for every device in some lists and do giant bulk POSTs for each import type at the very end of the run instead of the smaller ones I'm doing for each device individually to save some more time, but I haven't tested it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored all of the import functions to use bulk POSTs and list GETs instead of individual ones. In my testing, it took around 3.5 hours to import all device types before the change and about 20 minutes to import all device types after these modifications. I couldn't find any style guidelines, so let me know if anything cosmetic or substantive needs to change. Thanks!