Skip to content

Update readme env #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 2, 2021
Merged

Update readme env #17

merged 5 commits into from
Mar 2, 2021

Conversation

@ndom91
Copy link
Contributor

@ndom91 ndom91 commented Feb 27, 2021

Hey Alex,

Just updated a few things including:

  • used dotenv for env vars
  • updated README
  • added LICENSE (i assumed it was MIT - feel free to change, delete, etc.)
  • added timing output to end of script, mine just ran pretty long on a full refresh and I would have liked to know how long it actually was. small change.

minitriga
minitriga reviewed Mar 2, 2021
View reviewed changes
Copy link
Collaborator

@minitriga minitriga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@minitriga minitriga merged commit b499a97 into netbox-community:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@minitriga minitriga minitriga left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ndom91 @minitriga