Glob #61
Merged
Glob #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see some pretty basic problems with
Dir#glob. This pull requests fixes just one of them: globs on the root directory/fail since the logic to remove a trailing slash on the initial path made the root path the empty string"". Then#entries()failed. (This still doesn't fix multiple trailing slashes).The other problems that I see are:
globalways recurses (so globbing from/is never really practical, except on very small machines)::Dir.globyet both the signature and the semantics differ.Unfortunately to fix these problems (first, last) requires a backwards-incompatible change and a major version bump (respecting semver). (At least a change in signature is a clear signal to consumers). Would this project accept a PR for the above items at this stage in its life?