Skip to content

MonoCecilTempGenerator - only check path if assembly not already loaded #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

MonoCecilTempGenerator - only check path if assembly not already loaded #143

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c91708f
MonoCecilTempGenerator - only check path if not already loaded
K0lb3 Jun 2, 2025
85a3d02
MonoCecilTempGenerator - use lock for accessing loadedAssemblies in G…
K0lb3 Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions AssetsTools.NET.MonoCecil/MonoCecilTempGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,27 @@ public AssetTypeTemplateField GetTemplateField(AssetTypeTemplateField baseField,
assemblyName += ".dll";
}

string assemblyPath = Path.Combine(managedPath, assemblyName);
if (!File.Exists(assemblyPath))
List<AssetTypeTemplateField> newFields = null;

// if the assembly is already loaded, use it
lock (loadedAssemblies)
{
return null;
if (loadedAssemblies.TryGetValue(assemblyName, out AssemblyDefinition asmDef))
{
newFields = Read(asmDef, nameSpace, className, unityVersion);
}
}

List<AssetTypeTemplateField> newFields = Read(assemblyPath, nameSpace, className, unityVersion);
// otherwise, try to read it from the managed path
if (newFields == null)
{
string assemblyPath = Path.Combine(managedPath, assemblyName);
if (!File.Exists(assemblyPath))
{
return null;
}
newFields = Read(assemblyPath, nameSpace, className, unityVersion);
}

AssetTypeTemplateField newBaseField = baseField.Clone();
newBaseField.Children.AddRange(newFields);
Expand Down